As far as I can read it, this isn't affected the resists you can get.
You've always had the resists, it was just giving them to you AGAIN
(which does nothing). Now you just aren't getting duplicated resists at
all.


Ishuli's more or less saying how it worked previously -

If you're resist X (via whatever reason), and Favor of the Sun tried to
give you that resist, it would apply the affect to give you the resist
again...but that does nothing. If the other affect wears off, it takes
the resist with it. This could make it so that Favor of the Sun thinks
it's giving you resist still, but isn't, but also prevent you from
renewing the resist via other methods.



How it works now -

You resist something, and Favor of the Sun tries to give you that resist
again. Code notices that, and aborts the 2nd favor of the sun affect.


Net change: No differences in the resists you receive. In the new case,
you should never be BLOCKED from renewing a protection due to the code
thinking you have it when you don't now.


Admittedly I could be misunderstanding what's happening, but I don't
think you're losing anything here.