Help file included, but specifically this part:
Inspired by the drive for war beneath a bloody banner, the banner's
bearer also gains an extra attack with their weapon.

It does seem this works on NPC's as I certainly notice the damage however gaining an extra attack does not seem to be the case given the large sample of combat rounds with only one attack and no combat rounds that exceed 3 attacks according to the help file 4 should be possible.


'FASHION WAR BANNER' FASHIONWARBANNER
Syntax: fashionwarbanner <PC corpse>

By using this skill, an Orc uses a fallen foe as the source of materials
for a banner used in declaration of war against a given race. Although
the target corpse is not destroyed when this skill is used, some of its
possessions will be used to empower the banner itself. When carried by
a group leader, the banner confers beneficial properties to all Orcs
within the group so long as they are with the banner's bearer. The banner
raises morale, is useful to other Orc skills, and provides increased
savageness to the bearer against the race for which it was fashioned.

Inspired by the drive for war beneath a bloody banner, the banner's bearer
also gains an extra attack with their weapon.

That you can MAKE them from NPCs? That doesn't seem right.

That NPCs can HOLD the banner?

That the banner works, while held by you, against NPC mobs?

I glanced around the code even though I didn't really know what you were saying, and everything still seems fine to me.

I can see how what I said was confusing, thanks for the response.

"Inspired by the drive for war beneath a bloody banner, the banner's
bearer also gains an extra attack with their weapon."

This indicates I should get an extra attack when using a banner I do not and in this particular example I used a dwarf banner (From a player corpse ... Only way you can get them) against a dwarf NPC and noticed an improvement in damage (So I assume banners work when fighting NPC's) but not once noticed an extra attack. One attack a round happens very frequently and three attacks a round is the max when according to the help file I should see four.

This was a much larger thing than expected.

So the issue was with items that are "lights". Torches, some other items, and strangely enough orcish war banners.

All CF lights were ####ed up. Because of that, most of the fancy stuff they were meant to do wasn't working.

Meaning orc war banners haven't worked for... A while. As in vs npc OR pc.

Well guess what.

Now they work, and they work real well. You'll actually get the correct bonus from war banners, and from *any* item that was a light that wasn't working correctly.

Thanks for reporting this one and sending me down the rabbit hole.

Thanks for the follow up and glad it seems to have resolved a number of other issues as well!

Next time I send you down a rabbit hole I will try my best to ensure that there is a mad hatter and a tea party at the end of it all!